configure --set support list as arguments #109702
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
chenyukang
commented
Mar 28, 2023
chenyukang
commented
Mar 28, 2023
| build = self.serialize_and_parse(["--set", "rust.codegen-backends=cranelift"]) | ||
| self.assertNotEqual(build.config_toml.find("codegen-backends = ['cranelift']"), -1) | ||
| build = self.serialize_and_parse(["--set", "rust.codegen-backends=cranelift,llvm"]) | ||
| self.assertNotEqual(build.config_toml.find("codegen-backends = ['cranelift', 'llvm']"), -1) |
There was a problem hiding this comment.
I use config_toml.find here because get_string don't support list right now.
I think we need to rewrite get_toml, regular expression match seems won't work well 😂
|
I don't have time for reviews right now, please don't assign me. r? bootstrap |
|
Welcome @albertlarsan68! I will check on this within the week. |
|
Ping @albertlarsan68 |
|
☔ The latest upstream changes (presumably #110546) made this pull request unmergeable. Please resolve the merge conflicts. |
chenyukang
force-pushed
the
yukang/fix-109316-configure
branch
from
70319ed to
bbbb478
Compare
|
Thanks for the PR! |
|
📌 Commit bbbb478881dc02f17679cee90e129512dcb96c7a has been approved by It is now in the queue for this repository. |
bors
added
S-waiting-on-bors
|
⌛ Testing commit bbbb478881dc02f17679cee90e129512dcb96c7a with merge 916b7fe9c67b07f5c55d4b842f5c989ea5149d46... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
albertlarsan68
added
S-waiting-on-author
chenyukang
force-pushed
the
yukang/fix-109316-configure
branch
from
bbbb478 to
787f3fe
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 28, 2023
Rollup of 7 pull requests Successful merges: - rust-lang#109702 (configure --set support list as arguments) - rust-lang#110620 (Document `const {}` syntax for `std::thread_local`.) - rust-lang#110721 (format panic message only once) - rust-lang#110881 (refactor(docs): remove macro resolution fallback) - rust-lang#110893 (remove inline const deadcode in typeck) - rust-lang#110898 (Remove unused std::sys_common::thread_local_key::Key) - rust-lang#110909 (Skip `rustc` version detection on macOS) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109316
r? @jyn514